Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(theme:modal): perf code #1671

Merged
merged 1 commit into from
Oct 22, 2023
Merged

perf(theme:modal): perf code #1671

merged 1 commit into from
Oct 22, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 22, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Oct 22, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #1671 (a112e33) into master (3d6e016) will decrease coverage by 0.02%.
The diff coverage is 87.50%.

❗ Current head a112e33 differs from pull request most recent head ac83b22. Consider uploading reports for the commit ac83b22 to get more accurate results

@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   96.17%   96.16%   -0.02%     
==========================================
  Files         282      282              
  Lines        8758     8758              
  Branches     1649     1649              
==========================================
- Hits         8423     8422       -1     
- Misses        323      324       +1     
  Partials       12       12
Files Coverage Δ
packages/theme/src/services/modal/modal.helper.ts 89.28% <87.50%> (ø)

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit 341ff56 into master Oct 22, 2023
9 checks passed
@cipchk cipchk deleted the issues-modal-padding-bottom branch October 22, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipchk @ng-alain-bot